jiajunwang commented on a change in pull request #1401:
URL: https://github.com/apache/helix/pull/1401#discussion_r493972644
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAutoRebalance.java
##########
@@ -229,6 +236,16 @@ static boolean verifyBalanceExternalView(ZNRecord
externalView, int partitionCou
return partitionCount == totalCount;
}
+ private void setupAutoRebalancer() {
+ HelixAdmin admin = _gSetupTool.getClusterManagementTool();
Review comment:
This test is for testing AutoRebalancer, so no matter what's the default
behavior change, it is the right test logic. If it fails, then the new code
change shall be fixed. I think there is no necessity of adding comment. Because
this change only makes the logic more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
