lei-xia commented on a change in pull request #1441:
URL: https://github.com/apache/helix/pull/1441#discussion_r500498280
##########
File path: helix-core/src/main/java/org/apache/helix/GroupCommit.java
##########
@@ -112,6 +112,9 @@ public boolean commit(BaseDataAccessor<ZNRecord> accessor,
int options, String k
merged = accessor.get(mergedKey, null, options);
} catch (ZkNoNodeException e) {
// OK.
+ } catch (Exception e) {
Review comment:
Can you search all existing use cases (no related to customized state)
and make sure there is no assumption on old behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
