zhangmeng916 commented on a change in pull request #1441:
URL: https://github.com/apache/helix/pull/1441#discussion_r500531715
##########
File path: helix-core/src/main/java/org/apache/helix/GroupCommit.java
##########
@@ -112,6 +112,9 @@ public boolean commit(BaseDataAccessor<ZNRecord> accessor,
int options, String k
merged = accessor.get(mergedKey, null, options);
} catch (ZkNoNodeException e) {
// OK.
+ } catch (Exception e) {
Review comment:
This change only impacts group commit. As shown in the following, only
current state and customized state use group commit.
case CURRENTSTATES:
case CUSTOMIZEDSTATES:
success = _groupCommit.commit(_baseDataAccessor, options, path,
value.getRecord(), true);
However, as you mentioned, for normal update, there're cases that don't
really check response. I'll take a look to see whether they're reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
