kaisun2000 commented on a change in pull request #1441:
URL: https://github.com/apache/helix/pull/1441#discussion_r500598458
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -1315,8 +1315,11 @@ public void addTypeToCustomizedStateConfig(String
clusterName, String type) {
ZKHelixDataAccessor accessor =
new ZKHelixDataAccessor(clusterName, new
ZkBaseDataAccessor<ZNRecord>(_zkClient));
PropertyKey.Builder keyBuilder = accessor.keyBuilder();
- accessor.updateProperty(keyBuilder.customizedStateConfig(),
- customizedStateConfigFromBuilder);
+ if(!accessor.updateProperty(keyBuilder.customizedStateConfig(),
Review comment:
This pull only deals with exception in group commit. How about the
zkclient closed issue in callbackhandler?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
