jiajunwang commented on a change in pull request #1452: URL: https://github.com/apache/helix/pull/1452#discussion_r502131186
########## File path: helix-core/src/test/java/org/apache/helix/ThreadLeakageChecker.java ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.helix; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.Predicate; +import java.util.stream.Collectors; + +import org.apache.helix.common.ZkTestBase; + + +public class ThreadLeakageChecker { + private static ThreadGroup getRootThreadGroup() { + ThreadGroup candidate = Thread.currentThread().getThreadGroup(); + while (candidate.getParent() != null) { + candidate = candidate.getParent(); + } + return candidate; + } + + private static List<Thread> getAllThreads() { + ThreadGroup rootThreadGroup = getRootThreadGroup(); + Thread[] threads = new Thread[32]; + int count = rootThreadGroup.enumerate(threads); + while (count == threads.length) { + threads = new Thread[threads.length * 2]; + count = rootThreadGroup.enumerate(threads); + } + return Arrays.asList(Arrays.copyOf(threads, count)); + } + + private static final String[] ZKSERVER_THRD_PATTERN = + {"SessionTracker", "NIOServerCxn", "SyncThread:", "ProcessThread"}; + private static final String[] ZKSESSION_THRD_PATTERN = + new String[]{"ZkClient-EventThread", "ZkClient-AsyncCallback", "-EventThread", "-SendThread"}; + private static final String[] FORKJOIN_THRD_PATTERN = new String[]{"ForkJoinPool"}; + private static final String[] TIMER_THRD_PATTERN = new String[]{"time"}; + private static final String[] TASKSTATEMODEL_THRD_PATTERN = new String[]{"TaskStateModel"}; Review comment: How about new thread names or new threads that are not tracked by these patterns? As a minimum requirement, I suggest tracking unknown threads as well. And a limitation should be added onto those threads as well. So if anyone changes the name, or introducing new threads that are leaking, the test will break. And they will be forced to modify this section. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
