kaisun2000 commented on pull request #1452: URL: https://github.com/apache/helix/pull/1452#issuecomment-706342191
> Still, 2 problems that I also mentioned in the other test improvement PRs. > > 1. What is the guideline for using a system print vs. log? Without confirming this point, I cannot review it effectively. I prefer log, BTW. > 2. Why not throw an exception on leakage? If just print error, then we can just let the tool runs every night. There is no need to do it with every "mvn test". > For example, if people ignore the error, then we might figure it out weeks later. Then this check will be very less helpful. If we throw exception, current test won't work. I reduced the threads leakage from around 3000 to several hundreds at this point. Getting it to 0 is still some way to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
