lei-xia commented on a change in pull request #1452:
URL: https://github.com/apache/helix/pull/1452#discussion_r501992132
##########
File path: helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java
##########
@@ -127,8 +129,22 @@
protected Map<String, ClusterSetup> _clusterSetupMap = new HashMap<>();
protected Map<String, BaseDataAccessor> _baseDataAccessorMap = new
HashMap<>();
+ static public void reportPhysicalMemory() {
+ com.sun.management.OperatingSystemMXBean os =
(com.sun.management.OperatingSystemMXBean)
+ java.lang.management.ManagementFactory.getOperatingSystemMXBean();
+ long physicalMemorySize = os.getTotalPhysicalMemorySize();
+ System.out.println("************ SYSTEM Physical Memory:" +
physicalMemorySize);
+
+ int MB = 1024 * 1024;
Review comment:
minor: int -> long?
##########
File path: helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java
##########
@@ -710,7 +726,9 @@ protected Message createMessage(Message.MessageType type,
String msgId, String f
}
@AfterClass
- public void cleanupLiveInstanceOwners() {
+ public void cleanupLiveInstanceOwners() throws InterruptedException {
Review comment:
Will this method being called by all sub test classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
