NealSun96 opened a new pull request #1470:
URL: https://github.com/apache/helix/pull/1470
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #1469
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Cache selective update is a two step procedure. It first "lists", which gets
all the ZNodes, and then it "updates" by comparing ZNode metadata to determine
which ZNodes have been changed. Job enqueue is also a two step procedure, where
it adds all JobConfigs one by one, and update WorkflowConfig's DAG in the end.
If selective update "lists" before all JobConfigs are added, and "updates"
after the WorkflowConfig is done updating, it's possible to read in a DAG
containing more jobs than JobConfigs that are seen by selective update. This
causes TaskGarbageCollection to remove the jobs that are "missing" JobConfigs,
even though their JobConfigs actually exist. This PR implements a workaround
for determining expired jobs while avoiding this case of cache "phantom read":
if JobConfig doesn't exist in the cache, check ZK directly.
### Tests
- [x] The following is the result of the "mvn test" command on the
appropriate module:
```
[ERROR] Tests run: 1234, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
4,854.88 s <<< FAILURE! - in TestSuite
[ERROR]
testPeriodicRefresh(org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh)
Time elapsed: 2.022 s <<< FAILURE!
java.lang.AssertionError: expected:<4> but was:<3>
at
org.apache.helix.integration.spectator.TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh(TestRoutingTableProviderPeriodicRefresh.java:214)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestRoutingTableProviderPeriodicRefresh.testPeriodicRefresh:214
expected:<4> but was:<3>
[INFO]
[ERROR] Tests run: 1234, Failures: 1, Errors: 0, Skipped: 1
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:21 h
[INFO] Finished at: 2020-10-15T12:00:15-07:00
[INFO]
------------------------------------------------------------------------
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
