kaisun2000 commented on a change in pull request #1470:
URL: https://github.com/apache/helix/pull/1470#discussion_r508750460
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -81,8 +81,8 @@ public void process(ClusterEvent event) throws Exception {
if (nextPurgeTime <= currentTime) {
nextPurgeTime = currentTime + purgeInterval;
// Find jobs that are ready to be purged
- Set<String> expiredJobs =
- TaskUtil.getExpiredJobsFromCache(dataProvider, workflowConfig,
workflowContext);
+ Set<String> expiredJobs = TaskUtil
+ .getExpiredJobsFromCache(dataProvider, workflowConfig,
workflowContext, manager);
Review comment:
We can make something like "TaskUtil.getExpiredJobsFromCacheAndCheckZk"
deprecated once we fixed root of the selective update issue. The fix may take
several quarters though.
If you believe `TaskUtil.getExpiredJobsFromCache()` is not used by others.
Then shall we run this diff against TMC build to see parterners in upstream can
build against this one successfully? It would be much more costly if people
later find this thing does not work in release time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
