kaisun2000 commented on a change in pull request #1470:
URL: https://github.com/apache/helix/pull/1470#discussion_r508127444
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/TaskGarbageCollectionStage.java
##########
@@ -81,8 +81,8 @@ public void process(ClusterEvent event) throws Exception {
if (nextPurgeTime <= currentTime) {
nextPurgeTime = currentTime + purgeInterval;
// Find jobs that are ready to be purged
- Set<String> expiredJobs =
- TaskUtil.getExpiredJobsFromCache(dataProvider, workflowConfig,
workflowContext);
+ Set<String> expiredJobs = TaskUtil
+ .getExpiredJobsFromCache(dataProvider, workflowConfig,
workflowContext, manager);
Review comment:
Good point. Maybe let us create something like
`TaskUtil.getExpiredJobsFromCacheAndCheckZk` which uses
`TaskUtil.getExpiredJobsFromCache()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
