mgao0 commented on a change in pull request #1456:
URL: https://github.com/apache/helix/pull/1456#discussion_r508892056
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1299,6 +1308,10 @@ protected void
checkLiveInstancesObservation(List<LiveInstance> liveInstances,
}
public void shutdown() throws InterruptedException {
+ if (_periodicRebalancerFutureTasks != null) {
+ _periodicRebalancerFutureTasks.cancel(false);
+ }
+ _periodicalRebalanceExecutor.shutdown();
Review comment:
Yes shutdownPipeline() does shut down the event process thread, but when
you call shutdownNow, it's the thread inside the executor is shut down. I think
they are different threads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
