jiajunwang commented on a change in pull request #1456:
URL: https://github.com/apache/helix/pull/1456#discussion_r509792497
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1307,6 +1315,11 @@ public void shutdown() throws InterruptedException {
logger.info("Shutting down {} pipeline", Pipeline.Type.TASK.name());
shutdownPipeline(_taskEventThread, _taskEventQueue);
+ if (!_periodicalRebalanceExecutor
Review comment:
I think it is fine. But it would be easier for the reader to understand
if you put all the related logic together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
