xyuanlu commented on a change in pull request #1456:
URL: https://github.com/apache/helix/pull/1456#discussion_r509578225
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1307,6 +1315,11 @@ public void shutdown() throws InterruptedException {
logger.info("Shutting down {} pipeline", Pipeline.Type.TASK.name());
shutdownPipeline(_taskEventThread, _taskEventQueue);
+ if (!_periodicalRebalanceExecutor
Review comment:
TFTR.
Do you think it's better to do a _periodicalRebalanceExecutor.shutdownNow()
at beginning and then check if no thread is running like this here? Or just do
_periodicalRebalanceExecutor.shutdownNow() at beginning is enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
