rabashizade commented on a change in pull request #1732:
URL: https://github.com/apache/helix/pull/1732#discussion_r630654853
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
##########
@@ -874,13 +873,12 @@ private void unregisterAllEventMonitors() {
}
private void
registerPerInstanceResources(Collection<PerInstanceResourceMonitor> monitors)
- throws MalformedObjectNameException {
+ throws JMException {
synchronized (_perInstanceResourceMonitorMap) {
for (PerInstanceResourceMonitor monitor : monitors) {
String instanceName = monitor.getInstanceName();
String resourceName = monitor.getResourceName();
- String beanName = getPerInstanceResourceBeanName(instanceName,
resourceName);
- register(monitor, getObjectName(beanName));
Review comment:
Is it okay that this method (`private void register(Object bean,
ObjectName name)`) is still used in other places in the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
