zhangmeng916 commented on a change in pull request #1732:
URL: https://github.com/apache/helix/pull/1732#discussion_r630697993
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
##########
@@ -874,13 +873,12 @@ private void unregisterAllEventMonitors() {
}
private void
registerPerInstanceResources(Collection<PerInstanceResourceMonitor> monitors)
- throws MalformedObjectNameException {
+ throws JMException {
synchronized (_perInstanceResourceMonitorMap) {
for (PerInstanceResourceMonitor monitor : monitors) {
String instanceName = monitor.getInstanceName();
String resourceName = monitor.getResourceName();
- String beanName = getPerInstanceResourceBeanName(instanceName,
resourceName);
- register(monitor, getObjectName(beanName));
Review comment:
I see. So this register is only registering cluster status monitor,
which we haven't changed it yet. And inside cluster status monitor, other
monitors got registered individually with different methods. Once we start to
change cluster status monitor, we may need to handle its register from its
calling class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
