zhangmeng916 commented on a change in pull request #1732:
URL: https://github.com/apache/helix/pull/1732#discussion_r630681417
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
##########
@@ -874,13 +873,12 @@ private void unregisterAllEventMonitors() {
}
private void
registerPerInstanceResources(Collection<PerInstanceResourceMonitor> monitors)
- throws MalformedObjectNameException {
+ throws JMException {
synchronized (_perInstanceResourceMonitorMap) {
for (PerInstanceResourceMonitor monitor : monitors) {
String instanceName = monitor.getInstanceName();
String resourceName = monitor.getResourceName();
- String beanName = getPerInstanceResourceBeanName(instanceName,
resourceName);
- register(monitor, getObjectName(beanName));
Review comment:
Yeah, as long as we changed the register of workflow monitor and
perinstanceresource monitor to use the dynamic register, we shouldn't be
concerned about other places in this monitor. Later we may still need to change
them though if we would like to change corresponding monitors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
