narendly commented on code in PR #2082:
URL: https://github.com/apache/helix/pull/2082#discussion_r865964821
##########
helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java:
##########
@@ -43,6 +43,18 @@
*/
boolean create(String path, T record, int options);
+ /**
Review Comment:
General comment:
Good work. This is a very large PR - I think instead of trying to include
all changes in one single PR, it would help you and the reviewers to split this
up. This will help us:
- Enable modular development
- Facilitate review process (faster turnaround)
- Better quality of reviews
One way I could think of off the top of my head is to first focus on the
classes at the lowest level (e.g. ZkConnection, AsyncCallback, etc.) since we
need to get those right first. Then move up a layer (ZkClient). And then
another layer - (FederatedZkClient, DedicatedZkClient, etc. - these are all
similar, so once we get one right, we probably get the rest right). And next,
cover BaseDataAccessor and the like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
