rabashizade commented on PR #2082: URL: https://github.com/apache/helix/pull/2082#issuecomment-1122821548
> For adding TTL, don't you need to add some tests? This is a valid concern. However, as I explained in the PR description, the changes have been tested locally but since Zookeeper server makes no guarantee on exactly when the TTL nodes are deleted (see [here](https://zookeeper.apache.org/doc/r3.5.9/zookeeperProgrammers.html#TTL+Nodes)), the tests become flaky and as a result, are not added to this PR. I can add the tests, but we either need to wait a long time to be sure nodes are deleted, or we will see random test failures in the CI workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
