narendly commented on code in PR #2082:
URL: https://github.com/apache/helix/pull/2082#discussion_r870552261
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/callback/ZkAsyncCallbacks.java:
##########
@@ -111,12 +112,17 @@ protected void recordFailure(int rc, String path,
ZkAsyncCallMonitorContext moni
}
}
- public static class CreateCallbackHandler extends DefaultCallback implements
StringCallback {
+ public static class CreateCallbackHandler extends DefaultCallback implements
StringCallback, Create2Callback {
Review Comment:
Makes sense. I was expecting to see a new `Create2CallbackHandler`, but
since we're not doing much other than recording some stats in the monitor, I'm
fine with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
