xyuanlu commented on code in PR #2099:
URL: https://github.com/apache/helix/pull/2099#discussion_r873980336
##########
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java:
##########
@@ -37,6 +38,10 @@ public ClusterControllerManager(String zkAddr, String
clusterName, String contro
super(zkAddr, clusterName, controllerName, InstanceType.CONTROLLER);
}
+ public ClusterControllerManager(String clusterName, HelixManagerProperty
helixManagerProperty) {
Review Comment:
Tests in TestMultiZkConectionConfig do not have zkRouting env config set up
and we are building helixManagerProperty to connect to ZK. The connection will
fail when failing to read the Routing ZK.
```
RealmAwareZkClient.RealmAwareZkConnectionConfig.Builder
connectionConfigBuilder =
new RealmAwareZkClient.RealmAwareZkConnectionConfig.Builder();
RealmAwareZkClient.RealmAwareZkConnectionConfig validZkConnectionConfig =
connectionConfigBuilder
.setRoutingDataSourceEndpoint(_msdsEndpoint + "," + ZK_PREFIX +
ZK_START_PORT)
.setRoutingDataSourceType(RoutingDataReaderType.HTTP_ZK_FALLBACK.name())
.setZkRealmShardingKey("/" + clusterName).build();
HelixManagerProperty.Builder propertyBuilder = new
HelixManagerProperty.Builder()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
