xyuanlu commented on code in PR #2099:
URL: https://github.com/apache/helix/pull/2099#discussion_r884073573
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java:
##########
@@ -282,7 +282,8 @@ public ZKHelixManager(String clusterName, String
instanceName, InstanceType inst
// read cloud config from ZK and set cloudConfig in HelixManagerProperty
_helixManagerProperty = helixManagerProperty;
_helixManagerProperty.getHelixCloudProperty().populateFieldsWithCloudConfig(
- HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName));
+ HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName,
+ helixManagerProperty.getZkConnectionConfig()));
Review Comment:
helixManagerProperty.getZkConnectionConfig() returns an object of
`RealmAwareZkConnectionConfig`.
I our current Helix use case, the user is defining the multiZkRouting
endpoint in the `RealmAwareZkConnectionConfig`. However, the original
`getCloudConfig` create a zkClient only using the multiZkRouting in java env
variable. When user pass in the config but not set it in env variable, we will
fail to create zkClient even when user passed in correct config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
