xyuanlu commented on code in PR #2099:
URL: https://github.com/apache/helix/pull/2099#discussion_r880847277


##########
helix-core/src/main/java/org/apache/helix/HelixPropertyFactory.java:
##########
@@ -80,20 +80,23 @@ public HelixManagerProperty getHelixManagerProperty(String 
zkAddress, String clu
    * @param clusterName
    * @return
    */
-  public static CloudConfig getCloudConfig(String zkAddress, String 
clusterName) {
+  public static CloudConfig getCloudConfig(String zkAddress, String 
clusterName,
+      RealmAwareZkClient.RealmAwareZkConnectionConfig 
realmAwareZkConnectionConfig) {

Review Comment:
   Good point. Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to