xyuanlu commented on code in PR #2100:
URL: https://github.com/apache/helix/pull/2100#discussion_r874148705
##########
helix-rest/src/test/java/org/apache/helix/rest/server/TestInstancesAccessor.java:
##########
@@ -171,6 +173,11 @@ public void testUpdateInstances() throws IOException {
clusterConfig = _configAccessor.getClusterConfig(CLUSTER_NAME);
Assert.assertEquals(clusterConfig.getDisabledInstances().keySet(),
new HashSet<>(Arrays.asList(CLUSTER_NAME + "localhost_12919")));
+ Assert.assertEquals(clusterConfig.getDisabledInstancesWithInfo().keySet(),
+ new HashSet<>(Arrays.asList(CLUSTER_NAME + "localhost_12919")));
+ Assert.assertEquals(Long.parseLong(
+ clusterConfig.getInstanceHelixDisabledTimeStamp(CLUSTER_NAME +
"localhost_12919")),
+ Long.parseLong(clusterConfig.getDisabledInstances().get(CLUSTER_NAME +
"localhost_12919")));
Review Comment:
This test will add oldKey:oldFormat in cluster config znode and controller
will read it using getDisabledInstance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
