xyuanlu commented on code in PR #2100:
URL: https://github.com/apache/helix/pull/2100#discussion_r875327028
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/DelayedRebalanceUtil.java:
##########
@@ -139,10 +139,10 @@ private static long getInactiveTime(String instance,
Set<String> liveInstances,
// check the time instance got disabled.
if (!InstanceValidationUtil.isInstanceEnabled(instanceConfig,
clusterConfig)) {
long disabledTime = instanceConfig.getInstanceEnabledTime();
- Map<String, String> disabledInstances =
clusterConfig.getDisabledInstances();
- if (disabledInstances.containsKey(instance)) {
+ String batchedDisabledTime =
clusterConfig.getInstanceHelixDisabledTimeStamp(instance);
+ if (batchedDisabledTime != null && !batchedDisabledTime.isEmpty()) {
// Update batch disable time
- long batchDisableTime =
Long.parseLong(clusterConfig.getInstanceHelixDisabledTimeStamp(instance));
+ long batchDisableTime = Long.parseLong(batchedDisabledTime);
if (disabledTime == -1 || disabledTime > batchDisableTime) {
Review Comment:
The disabled time is read using system time. The format should not have
issue if user do not direct write to ZNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
