qqu0127 commented on code in PR #2100:
URL: https://github.com/apache/helix/pull/2100#discussion_r875346506
##########
helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java:
##########
@@ -77,18 +76,22 @@ public enum ClusterConfigProperty {
TARGET_EXTERNALVIEW_ENABLED,
@Deprecated // ERROR_OR_RECOVERY_PARTITION_THRESHOLD_FOR_LOAD_BALANCE will
take
- // precedence if it is set
- ERROR_PARTITION_THRESHOLD_FOR_LOAD_BALANCE, // Controller won't execute
load balance state
+ // precedence if it is set
+ ERROR_PARTITION_THRESHOLD_FOR_LOAD_BALANCE, // Controller won't
execute load balance state
// transition if the number of partitons that need
// recovery exceeds this limitation
ERROR_OR_RECOVERY_PARTITION_THRESHOLD_FOR_LOAD_BALANCE, // Controller
won't execute load balance
// state transition if the number of
// partitons that need recovery or in
// error exceeds this limitation
DISABLED_INSTANCES,
+ DISABLED_INSTANCES_WITH_INFO,
+ // disabled instances and disabled instances with info are for storing
batch disabled instances.
+ // disabled instances will write into both 2 fields for backward
compatibility.
VIEW_CLUSTER, // Set to "true" to indicate this is a view cluster
- VIEW_CLUSTER_SOURCES, // Map field, key is the name of source cluster,
value is
+ VIEW_CLUSTER_SOURCES, // Map field, key is the name of source clust:1175
+ // er, value is
Review Comment:
Is this intentional?
##########
helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java:
##########
@@ -77,18 +76,22 @@ public enum ClusterConfigProperty {
TARGET_EXTERNALVIEW_ENABLED,
@Deprecated // ERROR_OR_RECOVERY_PARTITION_THRESHOLD_FOR_LOAD_BALANCE will
take
- // precedence if it is set
- ERROR_PARTITION_THRESHOLD_FOR_LOAD_BALANCE, // Controller won't execute
load balance state
+ // precedence if it is set
+ ERROR_PARTITION_THRESHOLD_FOR_LOAD_BALANCE, // Controller won't
execute load balance state
Review Comment:
Indentation? Please ignore if this is just a UI display issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
