rabashizade opened a new pull request, #2120: URL: https://github.com/apache/helix/pull/2120
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved) ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In the recently added TTL feature to ZKClient, some tests are added which rely on `zookeeper.extendedTypesEnabled` system property to be set. This property was set in each of tests, and cleared at the end of the test. However, parallel execution of the tests resulted in the property being cleaned by one completed test while another test that relies on this property is still running. Due the test failures caused by this, the property is only set in the tests and never cleaned. ### Tests - [x] The following tests are written for this issue: (List the names of added unit/integration tests) - The following is the result of the "mvn test" command on the appropriate module: command: mvn -pl zookeeper-api test ``` [INFO] Results: [INFO] [INFO] Tests run: 66, Failures: 0, Errors: 0, Skipped: 0 ``` ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
