rabashizade commented on code in PR #2120:
URL: https://github.com/apache/helix/pull/2120#discussion_r883191094
##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -239,7 +239,6 @@ public void testSyncCreateWithTTL() {
Assert.assertNotNull(getRecord);
Assert.assertEquals(getRecord.getSimpleFields().size(), 0);
- System.clearProperty("zookeeper.extendedTypesEnabled");
Review Comment:
Do you mean in tests or in real world? In real world, it's never set from
Helix's/ZkClient's perspective. It would only be set on the ZK server, if it's
intended for the ZK to support TTL and Container modes. In tests, whenever we
want to test creating a ZNode in TTL or Container mode, this needs to be set.
Otherwise, ZK server throws an UnimplementedException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
