rabashizade commented on code in PR #2120:
URL: https://github.com/apache/helix/pull/2120#discussion_r882203058


##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -239,7 +239,6 @@ public void testSyncCreateWithTTL() {
     Assert.assertNotNull(getRecord);
     Assert.assertEquals(getRecord.getSimpleFields().size(), 0);
 
-    System.clearProperty("zookeeper.extendedTypesEnabled");

Review Comment:
   Some of the newly added tests need this property. But if we clear it in any 
of them, we run the risk of failing some other test that expects it to be there 
but finds it's not. Unless there's a way to avoid parallel test execution 
between different classes, I don't know how to get around this. Please let me 
know if you have any suggestions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to