qqu0127 opened a new pull request, #2199: URL: https://github.com/apache/helix/pull/2199
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Resolves https://github.com/apache/helix/issues/2198 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: A few terms used: 1. Source clusters -- the source clusters normally from different fabrics that the view aggregator aggregate data from 2. View cluster data -- the aggregated cluster data view from the source clusters 3. Local cache -- the local copy of view cluster data This PR Implements a cache synchronization mechanism to refresh local cache in `ViewClusterRefresher` from view cluster data. This is to provide extra resilience in case of data change externally in view cluster data. If that happens, the previous implementation will lead to eventual data inconsistency. The cache is refactored as in `_viewClusterDataCache` to be a snapshot of remote view cluster data, the cache refresh happens at the beginning of each periodic refresh event. A data refresh from source cluster is triggered if a discrepancy is detected between local cache and remote view cluster data (source of truth) ### Tests - [X] The following tests are written for this issue: New test case in `TestHelixViewAggregator` and `TestBasicClusterDataCache` - The following is the result of the "mvn test" command on the appropriate module: [INFO] [INFO] --- maven-bundle-plugin:5.1.4:install (default-install) @ helix-view-aggregator --- [INFO] Installing org/apache/helix/helix-view-aggregator/1.0.5-SNAPSHOT/helix-view-aggregator-1.0.5-SNAPSHOT.jar [INFO] Writing OBR metadata [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Helix 1.0.5-SNAPSHOT: [INFO] [INFO] Apache Helix ....................................... SUCCESS [ 1.428 s] [INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 2.253 s] [INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 1.068 s] [INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 2.445 s] [INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 0.877 s] [INFO] Apache Helix :: Core ............................... SUCCESS [ 10.478 s] [INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 1.547 s] [INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 3.015 s] [INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 0.714 s] [INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 1.369 s] [INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.020 s] [INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 1.135 s] [INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 0.956 s] [INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 0.771 s] [INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 0.754 s] [INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 0.733 s] [INFO] Apache Helix :: View Aggregator .................... SUCCESS [ 1.220 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 31.472 s [INFO] Finished at: 2022-08-18T11:08:10-07:00 [INFO] ------------------------------------------------------------------------ ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
