qqu0127 commented on code in PR #2199:
URL: https://github.com/apache/helix/pull/2199#discussion_r951770063
##########
helix-view-aggregator/src/main/java/org/apache/helix/view/aggregator/HelixViewAggregator.java:
##########
@@ -191,14 +191,19 @@ private void handleSourceClusterEvent(ClusterViewEvent
event) {
_refreshViewCluster.set(true);
break;
case PeriodicViewRefresh:
- if (!_refreshViewCluster.get()) {
+ // refresh local view cluster data cache
Review Comment:
Short answer yes, it's already there.
There are two types of "refresh" here.
1. between view cluster and source clusters (across fabrics),
2. the other is between local view cluster data cache and remote view
cluster source of truth.
The first one is much heavier and is only triggered during periodic refresh
if a source cluster change is detected through notification, or item 2 is
diverged.
In the second case is more like integrity check, the divergence is
unexpected. It's checked during each refresh cycle, and its implementation
compares znode version as in `PropertyCache`, and it's actually selectively
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
