qqu0127 commented on code in PR #2199:
URL: https://github.com/apache/helix/pull/2199#discussion_r951773073
##########
helix-view-aggregator/src/main/java/org/apache/helix/view/aggregator/HelixViewAggregator.java:
##########
@@ -191,14 +191,19 @@ private void handleSourceClusterEvent(ClusterViewEvent
event) {
_refreshViewCluster.set(true);
break;
case PeriodicViewRefresh:
- if (!_refreshViewCluster.get()) {
+ // refresh local view cluster data cache
+ boolean cacheChanged =
_viewClusterRefresher.refreshViewClusterDataCache();
+ if (cacheChanged) {
+ logger.info("Detected change in view cluster data, trigger a
refresh");
+ } else if (!_refreshViewCluster.get()) {
Review Comment:
Yes,
https://github.com/apache/helix/blob/5a4cfc71a5bca3e5d87bafc627eb3b571deb162d/helix-view-aggregator/src/main/java/org/apache/helix/view/aggregator/HelixViewAggregator.java#L355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
