micahstubbs commented on code in PR #2255:
URL: https://github.com/apache/helix/pull/2255#discussion_r1004836780
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkConectionConfig.java:
##########
@@ -225,18 +220,6 @@ public void afterClass() throws Exception {
System.clearProperty(MetadataStoreRoutingConstants.MSDS_SERVER_ENDPOINT_KEY);
}
}
-
- boolean status = false;
- try {
- status = ThreadLeakageChecker.afterClassCheck(testClassName);
- } catch (Exception e) {
- LOG.error("ThreadLeakageChecker exception:", e);
- }
- // todo: We should fail test here once we achieved 0 leakage and remove
the following System print
- if (!status) {
- System.out.println(
- "---------- Test Class " + testClassName + " thread leakage
detected! ---------------");
- }
Review Comment:
Thanks for sharing the history @NealSun96!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
