qqu0127 commented on code in PR #2255:
URL: https://github.com/apache/helix/pull/2255#discussion_r1004868331
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java:
##########
@@ -124,7 +123,7 @@ private void setupZooKeepers() {
* @param zkAddress
* @return
*/
- protected ZkServer startZkServer(final String zkAddress) {
+ protected synchronized static ZkServer startZkServer(final String zkAddress)
{
Review Comment:
Good question. This method is public to its subclass, and I do want to
prevent creating with the same ZK address at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
