qqu0127 commented on code in PR #2255:
URL: https://github.com/apache/helix/pull/2255#discussion_r1004865119
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestSharedZkClient.java:
##########
@@ -40,7 +40,7 @@ public void beforeClass() throws IOException,
InvalidRoutingDataException {
_realmAwareZkClientFactory = SharedZkClientFactory.getInstance();
}
- @Test
+ @Test(dependsOnMethods = "testRealmAwareZkClientCreation")
Review Comment:
`RealmAwareZkClientFactoryTestBase` is extended in both `TestSharedZkClient`
and `TestDedicatedZkClient`. Putting this method in the base class will cause
duplicated test and logic change in its other subclass. So I think it's better
to keep it this way. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
