rahulrane50 commented on code in PR #2325:
URL: https://github.com/apache/helix/pull/2325#discussion_r1061004530
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2553,6 +2557,13 @@ public void connect(final long
maxMsToWaitUntilConnected, Watcher watcher)
close();
}
}
+ try {
+ if (_monitor != null) {
+ _monitor.register();
Review Comment:
I just saw that you are correct according to current code. Although connect
API is public method, it's currently getting called only through constructor
but if we want it that way that it should be called only once then may be we
should add some sanity check before registering. I'm not sure what is the harm
in registration.
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2553,6 +2557,13 @@ public void connect(final long
maxMsToWaitUntilConnected, Watcher watcher)
close();
}
}
+ try {
+ if (_monitor != null) {
+ _monitor.register();
Review Comment:
Also noticed that on line 2520, does it expect that monitor is already
registered and then it tries to do that operation with monitor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
