qqu0127 commented on code in PR #2325:
URL: https://github.com/apache/helix/pull/2325#discussion_r1061083314
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -239,16 +250,8 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
} else {
LOG.info("ZkClient monitor key or type is not provided. Skip
monitoring.");
}
-
- connect(connectionTimeout, this);
-
- try {
- if (_monitor != null) {
- _monitor.register();
- }
- } catch (JMException e){
- LOG.error("Error in creating ZkClientMonitor", e);
- }
+ // set the zookeeper watcher for notification, use "this" native zkclient
instance by default if not explicitly set
+ _watcher = watcher == null ? this : watcher;
Review Comment:
No, the current behavior remains the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
