qqu0127 commented on code in PR #2325:
URL: https://github.com/apache/helix/pull/2325#discussion_r1060728353
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2499,7 +2503,7 @@ public Object call() throws Exception {
* @throws IllegalStateException
* if the connection timed out due to thread interruption
*/
- public void connect(final long maxMsToWaitUntilConnected, Watcher watcher)
+ public void connect(final long maxMsToWaitUntilConnected, @Nullable Watcher
watcher)
Review Comment:
That basically means there is no watcher for zookeeper notification, and
even NPE, I don't think it's a valid use case. Let me know if that makes sense
to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
