desaikomal commented on code in PR #2459:
URL: https://github.com/apache/helix/pull/2459#discussion_r1179818656
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1988,12 +1989,12 @@ public <T> T retryUntilConnected(final Callable<T>
callable)
retryCauseCode = e.code();
// we give the event thread some time to update the status to
'Disconnected'
Thread.yield();
- waitForRetry();
+ waitForRetry(retryCount++);
Review Comment:
thanks for the review. there are multiple places where waitForRetry()is
invoked and there are few other places where we exit right away. Encapsulating
in waitForRetry() seems like a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
