desaikomal commented on code in PR #2459:
URL: https://github.com/apache/helix/pull/2459#discussion_r1179818851
##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java:
##########
@@ -913,6 +913,79 @@ public void testRetryUntilConnectedAfterConnectionLoss()
_zkClient.delete(path);
}
+ /*
+ * Test the scenario where we have actually lost connection to ZK but
+ * the internal client connection state assumes that we are still connected.
+ * Once we re-start the ZK, the creation operation will finish.
+ * How this test simulates the steps is:
+ * 1. Shuts down zk server
+ * 2. Starts a creation thread to create an ephemeral node in the original
zk session
+ * 3. Creation operation loses connection and keeps retrying
+ * 4. Restarts zk server and Zk session is recovered
+ * 5. zk client reconnects successfully and creates an ephemeral node
+ */
+ @Test(timeOut = 5 * 60 * 1000L)
Review Comment:
thanks for the suggestion, let me try that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
