desaikomal commented on code in PR #2459:
URL: https://github.com/apache/helix/pull/2459#discussion_r1181782920


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1965,6 +1968,8 @@ public <T> T retryUntilConnected(final Callable<T> 
callable)
     if (_monitor != null) {
       _monitor.increaseOutstandingRequestGauge();
     }
+    int retryCount = 1;
+    ExponentialBackoffStrategy retryStrategy = new 
ExponentialBackoffStrategy(_operationRetryTimeoutInMillis, true);

Review Comment:
   We are combining cleanup and actual fix in the same review. Let me split the 
review in 2 different PR. one purely cleanup and another using the new 
cleaned-up API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to