desaikomal opened a new pull request, #2546: URL: https://github.com/apache/helix/pull/2546
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved) ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This change is focused on changes to core logic and has not done any additional code cleanup, de-dup etc. There are 3 more changes planned for the change once core logic is checked-in. Change-1: code dedup across computeBestPossibleStateForPartition Change-2: moving the message procesing state to 'DataProcess' stage of the pipeline. Change-3: This is may be: to add metrics to indicate that we diverted from 'preferred list' The core logic is as follows: Pre-Compute stage ------------------ - in WAGED rebalancer: computeNewIdealState, we create 'WagedInstanceCapacity' which tracks instance capacity and WeightProvider for partitions. These changes were introduced in Part-1. - We process the pending messages for the resources where if we are moving out partition but not yet moved, we reduce the capacity. Once we compute the ideal state, we go through preference list sorting. There are no changes to the pure computational change. Post-compute stage ------------------ We look at the current-state as well as ideal state, we combine the list and do the sorting of the nodes. We then pick up only the required numReplica nodes. This is where we look at the nodes which are "NEW" (ie. not in currentState) and check if it has the required capacity to hold the new partition. If not, we remove it from combined list. ### Tests - [ ] The following tests are written for this issue: (List the names of added unit/integration tests) - The following is the result of the "mvn test" command on the appropriate module: Testing done: Have run through the mvn test (10 times) In another change, I have added a new test case and verified that it works. [ERROR] Failures: [ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true> [ERROR] TestClusterMaintenanceMode.testMaintenanceHistory:412 expected:<EXIT> but was:<ENTER> [ERROR] TestParticipantFreeze.testUnfreezeParticipant:228 expected:<true> but was:<false> [ERROR] TestRecurringJobQueue.testDeletingRecurrentQueueWithHistory:298 expected:<true> but was:<false> [ERROR] Tests run: 1335, Failures: 4, Errors: 0, Skipped: 0 (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
