junkaixue commented on code in PR #2546:
URL: https://github.com/apache/helix/pull/2546#discussion_r1248139890


##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java:
##########
@@ -274,59 +276,208 @@ public ResourceAssignment 
computeBestPossiblePartitionState(ResourceControllerDa
     return partitionMapping;
   }
 
+
   @Override
   protected Map<String, String> 
computeBestPossibleStateForPartition(Set<String> liveInstances,

Review Comment:
   My bad. This method cannot be changed because AbstractRebalancer has been 
extended by user. Change method signature would lead build break...
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to