desaikomal commented on code in PR #2546:
URL: https://github.com/apache/helix/pull/2546#discussion_r1244318312
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java:
##########
@@ -408,4 +420,129 @@ private int getNumExtraReplicas(ClusterConfig
clusterConfig) {
}
return numExtraReplicas;
}
+
+
+ private Map<String, String>
computeBestPossibleStateForPartition(ResourceControllerDataProvider cache,
Review Comment:
As I wrote in my change description, I will make the dedup effort as next
change. Trying to make code easy to read and reason through. There are 3 more
changes planned (but this is the core-logic). Other 3 changes are: 1. dedup
code. 2. move the process() logic to DataProcessing stage and (3) add the
metrics.
So can you please review for "CORRECTNESS"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
