MarkGaox opened a new pull request, #2587:
URL: https://github.com/apache/helix/pull/2587
### Issues
- [X] My PR addresses the following Helix issues and references them in the
PR description:
#2348 #2551
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Write a short fix for TestP2PNoDuplicatedMessage by capping the success
rate to 80 percent as in github environment ZK access can be slow.
### Tests
- [X] The following tests are written for this issue:
TestP2PNoDuplicatedMessage
- The following is the result of the "mvn test" command on the appropriate
module:
(If CI test fails due to known issue, please specify the issue and test PR
locally. Then copy & paste the result of "mvn test" to here.)
```
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
71.533 s - in org.apache.helix.integration.messaging.TestP2PNoDuplicatedMessage
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core
---
[INFO] Loading execution data file
/Users/xiaxgao/IdeaProjects/helix_ps/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 943 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:21 min
[INFO] Finished at: 2023-08-09T16:16:17-07:00
[INFO]
------------------------------------------------------------------------
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
