desaikomal commented on code in PR #2587:
URL: https://github.com/apache/helix/pull/2587#discussion_r1289362807
##########
helix-core/src/test/java/org/apache/helix/integration/messaging/TestP2PNoDuplicatedMessage.java:
##########
@@ -176,8 +176,8 @@ public void testP2PStateTransitionEnabled() {
// The success rate really depends on how quick participant act in
relationship with controller.
// For now, we set 90% threshold.
Review Comment:
Congrats on first code-review. Can you please change the comment as well?
also i don't have full context on why 80 would work and not 90.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
