MarkGaox commented on code in PR #2587:
URL: https://github.com/apache/helix/pull/2587#discussion_r1289395832
##########
helix-core/src/test/java/org/apache/helix/integration/messaging/TestP2PNoDuplicatedMessage.java:
##########
@@ -176,8 +176,8 @@ public void testP2PStateTransitionEnabled() {
// The success rate really depends on how quick participant act in
relationship with controller.
// For now, we set 90% threshold.
Review Comment:
Thanks for the quick review! I'm suspecting that this unit test is buggy due
to the limited github action resource. As the previous author mentioned, this
would cause the state transition of participant falls behind the time when the
`verifyP2PEnabled()` method reads the ZK. Thus, lowering down the threshold
could potentially avoid this issue. To monitor the effect of this change,
another line is added to log the number of successful P2P transition and total
transitions expected, which would make debugging this issue a little bit easier
if it comes back in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
