rahulrane50 commented on code in PR #2591:
URL: https://github.com/apache/helix/pull/2591#discussion_r1294008053
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -491,6 +491,12 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
true);
}
}
+
+ // In case of recovery after failure, we should decrement the
missingTopStateBeyondThresholdGauge value.
+ if (clusterStatusMonitor != null && record.isFailed()) {
Review Comment:
Also to second one, we want to keep fallback backup reset mechanism to reset
the metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
