GrantPSpencer opened a new pull request, #2759: URL: https://github.com/apache/helix/pull/2759
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: N/A ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: ZooKeeper allows for calling delete with an expected version, where the znode will only be deleted if the version in the znode's stat matches the passed version number. This PR adds APIs to the ZKClients to call delete with expected version Also adds to the baseDataAccessors the API for remove with expected version. ### Tests - [x] The following tests are written for this issue: ``` TestZKBaseDataAccessor.java - testRemoveWithExpectedVersion RealmAwareZkClientFactoryTestBase.java - testDeleteExpectedVersion TestFederatedZkClient.java - testDeleteExpectedVersion ``` - [x] The following is the result of the "mvn test" command on the appropriate module: CI run against my fork passed https://github.com/GrantPSpencer/helix/actions/runs/7909844995/job/21591541741?pr=5 ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: N/A. The original delete and remove methods just call the new method and pass in -1 as the expected version (meaning no version match is forced) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
