GrantPSpencer commented on PR #2759: URL: https://github.com/apache/helix/pull/2759#issuecomment-1965434299
@junkaixue @MarkGaox @xyuanlu Thanks for reviews. Unfortunately commit history got messed up and had to force push to fastforward. I addressed comments in the most recent commit (["remove with expected version no longer recursively deletes"](https://github.com/apache/helix/pull/2759/commits/8b9b5d09e5ee412eed53653e1c7f14d0efdbe312)) Important change is that I've decoupled remove and "remove with expected version" in the BaseDataAcessor. Original remove method attempts to recursively delete if the in initial delete fails. The new "remove with expected version" method should not have this recursive delete behavior as it can lead to race condition between initial delete and call to recursive delete. It will now fail if the property is not a leaf node. Should I now rename remove with expected version to a separate method entirely or stay with the method overloading? The difference in recursive behavior may not be immediately clear to customers. I appreciate your guys' help in improving my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
