GrantPSpencer commented on PR #2759: URL: https://github.com/apache/helix/pull/2759#issuecomment-1947654193
> The implementation looks fine to me. Be careful with when to use it. When it failed to delete, you need to handle it properly as the exception has been swallowed in the inner part. Do you think this should throw ZKBadversion exception at the dataAccessor.remove() level as well? Catching and throwing false is in line with current behavior of remove() method, but it is not clear for what reason the removal failed. Maybe we should throw it so that callers can implement logic specific to version mismatches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
